Skip to content

more protections against data corruption#1812

Open
pavel1murat wants to merge 1 commit into
Mu2e:mainfrom
pavel1murat:murat/sdmaker
Open

more protections against data corruption#1812
pavel1murat wants to merge 1 commit into
Mu2e:mainfrom
pavel1murat:murat/sdmaker

Conversation

@pavel1murat
Copy link
Copy Markdown
Contributor

@pavel1murat pavel1murat commented Apr 26, 2026

  • protect code against couple of more observed data corruption cases

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Apr 26, 2026

Hi @pavel1murat,
You have proposed changes to files in these packages:

  • DAQ

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for 3729ee2: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Apr 26, 2026

☔ The build tests failed for 3729ee2.

Test Result Details
test with ✅ Command did not list any other PRs to include
merge ✅ Merged 3729ee2 at 5912724
build (prof) ✅ Log file. Build time: 04 min 21 sec
ceSimReco ✅ Log file.
g4test_03MT ✅ Log file.
transportOnly ✅ Log file.
POT ✅ Log file.
g4study ✅ Log file.
cosmicSimReco ✅ Log file.
cosmicOffSpill ❌ Log file. Return Code 9.
ceSteps ✅ Log file.
ceDigi ❌ Log file. Return Code 9.
muDauSteps ✅ Log file.
ceMix ❌ Log file. Return Code 9.
rootOverlaps ✅ Log file.
g4surfaceCheck ✅ Log file.
trigger ❌ Log file. Return Code 2.
check_cmake ✅ Log file.
FIXME, TODO ✅ TODO (0) FIXME (0) in 1 files
clang-tidy ➡️ 15 errors 23 warnings
whitespace check ➡️ found whitespace errors

N.B. These results were obtained from a build of this Pull Request at 3729ee2 after being merged into the base branch at 5912724.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@oksuzian
Copy link
Copy Markdown
Collaborator

oksuzian commented May 23, 2026

@FNALbuild run build test

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 23, 2026

⌛ The following tests have been triggered for 3729ee2: build (Build queue - API unavailable)

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 23, 2026

☔ The build tests failed for 3729ee2.

Test Result Details
test with ✅ Command did not list any other PRs to include
merge ✅ Merged 3729ee2 at 9c0a491
build (prof) ✅ Log file. Build time: 04 min 13 sec
ceSimReco ✅ Log file.
g4test_03MT ✅ Log file.
transportOnly ✅ Log file.
POT ✅ Log file.
g4study ✅ Log file.
cosmicSimReco ✅ Log file.
cosmicOffSpill ❌ Log file. Return Code 9.
ceSteps ✅ Log file.
ceDigi ❌ Log file. Return Code 9.
muDauSteps ✅ Log file.
ceMix ❌ Log file. Return Code 9.
rootOverlaps ✅ Log file.
g4surfaceCheck ✅ Log file.
trigger ❌ Log file. Return Code 2.
check_cmake ✅ Log file.
FIXME, TODO ✅ TODO (0) FIXME (0) in 1 files
clang-tidy ➡️ 15 errors 23 warnings
whitespace check ➡️ found whitespace errors

N.B. These results were obtained from a build of this Pull Request at 3729ee2 after being merged into the base branch at 9c0a491.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 23, 2026

📝 The HEAD of main has changed to 479f139. Tests are now out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelmackenzie michaelmackenzie Awaiting requested review from michaelmackenzie

@edcallaghan edcallaghan Awaiting requested review from edcallaghan

Assignees

No one assigned

Labels

build pending

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pavel1murat @FNALbuild @oksuzian